[PATCH libinput 1/2] Hook up libevdev as backend

Rui Tiago Cação Matos tiagomatos at gmail.com
Tue Feb 18 04:53:47 PST 2014


On 18 February 2014 07:09, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> libevdev wraps the various peculiarities of the evdev kernel API into a
> type-safe API. It also buffers the device so checking for specific features at
> a later time is easier than re-issuing the ioctls. Plus, it gives us almost
> free support for SYN_DROPPED events (in the following patch).
>
> This patch switches all the bit checks over to libevdev and leaves the event
> processing as-is. Makes it easier to review.

This looks fine to me. Can we also add a

libevdev_set_clock_id(device->evdev, CLOCK_MONOTONIC);

on device creation? CLOCK_MONOTONIC is already a hard dependency in
configure.ac and it's required for good interoperability between
xwayland (which uses it for its time stamps) and mutter.

Rui


More information about the wayland-devel mailing list