[PATCH wayland 2/2] protocol: Clarify semantics of wl_subsurface.set_position

Bill Spitzak spitzak at gmail.com
Mon Jan 20 11:11:42 PST 2014


Rather than say "schedule the coordinate change" I think it would be 
clearer to say something like this:

"This changes the scheduled coordinates of the sub-surface."

"The next wl_surface.commit on the parent surface will reset the 
sub-surface's position to the scheduled coordinates."

"The initial position is 0, 0."

I think that makes it clear what happens if you call this more than once 
before a commit.

Jonas Ådahl wrote:
> Make it clear that multiple requests before commit are allowed and how it
> is handled.
> 
> Signed-off-by: Jonas Ådahl <jadahl at gmail.com>
> ---
>  protocol/wayland.xml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> index b986c86..d47ee62 100644
> --- a/protocol/wayland.xml
> +++ b/protocol/wayland.xml
> @@ -1931,6 +1931,10 @@
>  	The next wl_surface.commit on the parent surface will reset
>  	the sub-surface's position to the scheduled coordinates.
>  
> +	If more than one set_position request is invoked by the client before
> +	the commit of the parent surface, the position of a new request always
> +	replaces the scheduled position from any previous request.
> +
>  	The initial position is 0, 0.
>        </description>
>  


More information about the wayland-devel mailing list