[PATCH libinput 2/2] Remove mention of delta coordinates having device specific direction

Peter Hutterer peter.hutterer at who-t.net
Wed Jan 29 16:31:05 PST 2014


On Wed, Jan 29, 2014 at 09:33:12PM +0100, Jonas Ådahl wrote:
> The event represent pointer motions on a screen, so this information is
> unnecessary. It could also be confused for meaning the provided
> coordinate's direction being device specific.
> 
> Signed-off-by: Jonas Ådahl <jadahl at gmail.com>

just for the archives: what I meant with this sentence is that while the
positive x/y coordinates are right/down on the screen, there is no guarantee
that matches a device's notion of up/down. for example, if you hold a
graphics tablet upside down, the positive y direction is actually "up" on
the tablet (if it isn't software-rotated).

This is probably obvious anyway, and the extra documentation does little
other than adding confusion, so 
Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>.

Cheers,
   Peter

> ---
>  src/libinput.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/src/libinput.h b/src/libinput.h
> index 8d347b9..e2d83bf 100644
> --- a/src/libinput.h
> +++ b/src/libinput.h
> @@ -363,9 +363,9 @@ libinput_event_pointer_get_time(
>  /**
>   * @ingroup event_pointer
>   *
> - * Return the delta between the last event and the current event. The axis'
> - * positive direction is device-specific. For pointer events that are
> - * not of type LIBINPUT_EVENT_POINTER_MOTION, this function returns 0.
> + * Return the delta between the last event and the current event. For pointer
> + * events that are not of type LIBINPUT_EVENT_POINTER_MOTION, this function
> + * returns 0.
>   *
>   * @note It is an application bug to call this function for events other than
>   * LIBINPUT_EVENT_POINTER_MOTION.
> @@ -379,9 +379,9 @@ libinput_event_pointer_get_dx(
>  /**
>   * @ingroup event_pointer
>   *
> - * Return the delta between the last event and the current event. The
> - * axis' positive direction is device-specific. For pointer events that are
> - * not of type LIBINPUT_EVENT_POINTER_MOTION, this function returns 0.
> + * Return the delta between the last event and the current event. For pointer
> + * events that are not of type LIBINPUT_EVENT_POINTER_MOTION, this function
> + * returns 0.
>   *
>   * @note It is an application bug to call this function for events other than
>   * LIBINPUT_EVENT_POINTER_MOTION.
> -- 
> 1.8.3.2
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
> 


More information about the wayland-devel mailing list