[PATCH libinput] tablet: Rename TILT_VERTICAL and TILT_HORIZONTAL to TILT_X and TILT_Y

[Lyude]

You're completely right, I had worried I might do that by accident and
had thought I had checked to make sure I didn't. Gonna send a follow-up
patch in just a minute.

On Thu, 2014-07-10 at 11:40 -0700, Bill Spitzak wrote:
> 
> On 07/09/2014 10:29 PM, Peter Hutterer wrote:
> > On Wed, Jul 09, 2014 at 01:14:48AM -0400, Stephen Chandler Paul wrote:
> >> Since the orientation of the tablet can potentially change, this naming scheme
> >> makes a lot more sense then VERTICAL and HORIZONTAL does since they don't
> >> reflect the actual physical movement.
> 
> This looks backwards to me:
> 
> >>   	case ABS_TILT_X:
> >> -		axis = LIBINPUT_TABLET_AXIS_TILT_HORIZONTAL;
> >> +		axis = LIBINPUT_TABLET_AXIS_TILT_Y;
> >>   		break;
> >>   	case ABS_TILT_Y:
> >> -		axis = LIBINPUT_TABLET_AXIS_TILT_VERTICAL;
> >> +		axis = LIBINPUT_TABLET_AXIS_TILT_X;
> >>   		break;
> >>   	default:
> 
> I don't think you should reverse the meaning of the names fro whatever 
> evcode is using.
> 
> I suppose "TILT_X" can either mean "tilt in a plane parallel to the x 
> axis" or it can mean "tilt about the x axis". I think most people will 
> assume the first meaning but I can imagine either one being used. But in 
> any case two libraries should not disagree, right?
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20140710/09310237/attachment.sig>