[PATCH libinput 2/3] test: reduce sideways-component in two-finger scroll test

Hans de Goede hdegoede at redhat.com
Fri Jul 18 02:58:14 PDT 2014


Hi,

On 07/18/2014 09:01 AM, Peter Hutterer wrote:
> This breaks when we have a device resolution set on the test devices,
> specificially on the T440. The current tests use a delta of 1% of the device
> which with the resolution set results in an effective delta of 3 - above the
> scroll threshold.
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Looks good:

Reviewed-by: Hans de Goede <hdegoede at redhat.com>

Regards,

Hans

> ---
>  test/touchpad.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/test/touchpad.c b/test/touchpad.c
> index 5a19e05..3052519 100644
> --- a/test/touchpad.c
> +++ b/test/touchpad.c
> @@ -1198,15 +1198,13 @@ START_TEST(touchpad_2fg_scroll)
>  
>  	litest_drain_events(li);
>  
> -	/* Note this mixes in a tiny amount of movement in the wrong direction,
> -	   which should be ignored */
> -	test_2fg_scroll(dev, 1, 40, 0);
> +	test_2fg_scroll(dev, 0.1, 40, 0);
>  	check_2fg_scroll(dev, LIBINPUT_POINTER_AXIS_SCROLL_VERTICAL, 10);
> -	test_2fg_scroll(dev, 1, -40, 0);
> +	test_2fg_scroll(dev, 0.1, -40, 0);
>  	check_2fg_scroll(dev, LIBINPUT_POINTER_AXIS_SCROLL_VERTICAL, -10);
> -	test_2fg_scroll(dev, 40, 1, 0);
> +	test_2fg_scroll(dev, 40, 0.1, 0);
>  	check_2fg_scroll(dev, LIBINPUT_POINTER_AXIS_SCROLL_HORIZONTAL, 10);
> -	test_2fg_scroll(dev, -40, 1, 0);
> +	test_2fg_scroll(dev, -40, 0.1, 0);
>  	check_2fg_scroll(dev, LIBINPUT_POINTER_AXIS_SCROLL_HORIZONTAL, -10);
>  
>  	/* 2fg scroll smaller than the threshold should not generate events */
> 


More information about the wayland-devel mailing list