[PATCH libinput 3/3] touchpad: correct a wrong comment

Hans de Goede hdegoede at redhat.com
Fri Jul 18 02:59:10 PDT 2014


Hi,

On 07/18/2014 09:01 AM, Peter Hutterer wrote:
> The minimum to start 2fg scrolling is in device units, not pixels. Which is
> bad on many levels, but let's correct it in the comment at least.
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>  src/evdev-mt-touchpad.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
> index c7fd3a1..04c8ca5 100644
> --- a/src/evdev-mt-touchpad.c
> +++ b/src/evdev-mt-touchpad.c
> @@ -443,7 +443,7 @@ tp_post_twofinger_scroll(struct tp_dispatch *tp, uint64_t time)
>  
>  	tp_filter_motion(tp, &dx, &dy, time);
>  
> -	/* Require at least five px scrolling to start */
> +	/* Require at least five device units scrolling to start */

This is dx / dy after tp_filter_motion and thus after scaling + accel so this is
not in device units.

Regards,

Hans


>  	if (dy <= -5.0 || dy >= 5.0)
>  		tp->scroll.direction |= (1 << LIBINPUT_POINTER_AXIS_SCROLL_VERTICAL);
>  
> 


More information about the wayland-devel mailing list