[PATCH wayland v5] client: extend error handling

[Pekka Paalanen]

On Mon, 7 Jul 2014 17:41:25 +0300
Pekka Paalanen <ppaalanen at gmail.com> wrote:

> On Mon,  7 Jul 2014 17:28:11 +0300
> Pekka Paalanen <ppaalanen at gmail.com> wrote:
> 
> > From: Marek Chalupa <mchqwerty at gmail.com>
> > 
> > When an error occurs, wl_display_get_error() does not
> > provide any way of getting know if it was a local error or if it was
> > an error event, respectively what object caused the error and what
> > the error was.
> > 
> > This patch introduces a new function wl_display_get_protocol_error()
> > which will return error code, interface and id of the object that
> > generated the error.
> > wl_display_get_error() will work the same way as before.
> > 
> > wl_display_get_protocol_error() DOES NOT indicate that a non-protocol
> > error happened. It returns valid information only in that case that
> > (protocol) error occurred, so it should be used after calling
> > wl_display_get_error() with positive result.
> > 
> > [Pekka Paalanen] Applied another hunk of Bryce's comments to docs,
> > 	added libtool version bump.
> > 
> > Reviewed-by: Pekka Paalanen <ppaalanen at gmail.com>
> > Reviewed-by: Bryce Harrington <b.harrington at samsung.com>
> > ---
> >  Makefile.am          |   2 +-
> >  src/wayland-client.c | 137 ++++++++++++++++++++++++++++++++++++++++++++-------
> >  src/wayland-client.h |   3 ++
> >  3 files changed, 123 insertions(+), 19 deletions(-)
> > 
> > diff --git a/Makefile.am b/Makefile.am
> > index c15d8b8..fee19ab 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -51,7 +51,7 @@ nodist_libwayland_server_la_SOURCES =		\
> >  
> >  libwayland_client_la_CFLAGS = $(FFI_CFLAGS) $(GCC_CFLAGS) -pthread
> >  libwayland_client_la_LIBADD = $(FFI_LIBS) libwayland-util.la -lrt -lm
> > -libwayland_client_la_LDFLAGS = -version-info 2:0:2
> > +libwayland_client_la_LDFLAGS = -version-info 3:0:3
> >  libwayland_client_la_SOURCES =			\
> >  	src/wayland-client.c
> >  
> 
> Hi,
> 
> I did intend this as a reply to
> http://lists.freedesktop.org/archives/wayland-devel/2014-June/015532.html
> but messed up a bit.
> 
> I would like a one more reviewed-by for specifically the
> version-info bump that we get it right. Then I can push this.

Well, it seemed correct to me, and no-one complained, so pushed.


Thanks,
pq