[PATCH V3] Do not assume 64x64 cursor, added support for other sizes (like in AMD Kaveri, 128x128).

[Jason Ekstrand]

I pushed this one.  Let's get a follow-up that lets weston actually use the
bigger cursors.  It would also be good to hack together a little client
that attaches a big cursor so we can verify that it's working.  I don't
think we need to put it in the repo, I'd just like proof that we're
actually taking advantage of our new-found big cursors.
Thanks,
--Jason Ekstrand


On Tue, Jul 29, 2014 at 12:40 AM, Michel Dänzer <michel at daenzer.net> wrote:

> On 29.07.2014 16:36, Jason Ekstrand wrote:
> > On Tue, Jul 29, 2014 at 12:17 AM, Michel Dänzer <michel at daenzer.net
> > <mailto:michel at daenzer.net>> wrote:
> >
> >     On 29.07.2014 16:01, Jason Ekstrand wrote:
> >     > Couple thoughs.  First, we need to also update
> >     > drm_output_prepare_cursor_view to check against the size coming
> >     from GBM
> >     > instead of against the hard-coded 64x64 it's currently checking
> >     > against.  Without changing that, we are still restricted to 64x64
> >     > regardless of the GBM checking.
> >
> >     You mean weston will still refuse to use the hardware cursor for
> images
> >     larger than 64x64 without that change? That sounds like something
> that
> >     should indeed be fixed, though it's not really critical compared to
> the
> >     problem fixed by this patch, which is that the hardware cursor
> appears
> >     corrupted beyond usability on hardware which only supports hardware
> >     cursors of sizes other than 64x64.
> >
> >
> > Yup.  That is exactly what it means.  It should be a fairly easy fix.
> > If you'd rather I push this and fix in a follow-up patch, that's
> > probably ok,
>
> That would be great.
>
> > but let's make sure one is coming.
>
> Alvaro, do you want to send a follow-up patch addressing the issue Jason
> described above?
>
>
> --
> Earthling Michel Dänzer            |                  http://www.amd.com
> Libre software enthusiast          |                Mesa and X developer
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20140729/e8cad95d/attachment.html>