[PATCH libinput] Add our own version of linux/input.h

Peter Hutterer peter.hutterer at who-t.net
Tue Jun 3 15:05:49 PDT 2014


On Tue, Jun 03, 2014 at 08:54:38AM -0400, Jasper St. Pierre wrote:
> I think it should be #include "linux/input.h" at the very least.
> <a_header_file.h> has always meant "system library" to me.

amended locally, thanks.

Cheers,
   Peter

> On Tue, Jun 3, 2014 at 5:34 AM, Peter Hutterer <peter.hutterer at who-t.net>
> wrote:
> 
> > On 3/06/2014 17:06 , Thiago Macieira wrote:
> >
> >> Em ter 03 jun 2014, às 16:56:35, Peter Hutterer escreveu:
> >>
> >>> On Mon, Jun 02, 2014 at 10:01:20PM -0700, Thiago Macieira wrote:
> >>>
> >>>> Em ter 03 jun 2014, às 08:08:15, Peter Hutterer escreveu:
> >>>>
> >>>>> Avoids having to #define any values we're trying to use.
> >>>>>
> >>>>> Header file is from Linux 3.15-rc8.
> >>>>>
> >>>>> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> >>>>>
> >>>>
> >>>> Wouldn't this be time as well to start using a different include than
> >>>> <linux/input.h>?
> >>>>
> >>>
> >>> does it matter much? #include <linux/input.h> makes it clear which
> >>> header it
> >>> is, that we ship our own doesn't really change that.
> >>>
> >>
> >> I think we should start moving away from a linux/ header. If Wayland gets
> >> run
> >> on other OS, this header would mean "it happens to be the same values, but
> >> it's not really a Linux header".
> >>
> >
> > what's the technical benefit of that though?
> >
> > Cheers,
> >   Peter


More information about the wayland-devel mailing list