[PATCH wayland 2/2] protocol: add wl_surface errors enum for bad scale and transform values

[Pekka Paalanen]

On Tue, 3 Jun 2014 10:03:57 +0300
Pekka Paalanen <ppaalanen at gmail.com> wrote:

> On Fri, 30 May 2014 12:08:16 +0200
> Jonny Lamb <jonny.lamb at collabora.co.uk> wrote:
> 
> > ---
> >  protocol/wayland.xml | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> > index 3091d83..951aafc 100644
> > --- a/protocol/wayland.xml
> > +++ b/protocol/wayland.xml
> > @@ -982,6 +982,14 @@
> >        cursor images for pointers, drag icons, etc.
> >      </description>
> >  
> > +    <enum name="error">
> > +      <description summary="wl_surface error values">
> > +        These errors can be emitted in response to wl_surface requests.
> > +      </description>
> > +      <entry name="invalid_scale" value="0" summary="buffer scale value is invalid"/>
> > +      <entry name="invalid_transform" value="1" summary="buffer transform value is invalid"/>
> > +    </enum>
> > +
> >      <request name="destroy" type="destructor">
> >        <description summary="delete surface">
> >  	Deletes the surface and invalidates its object ID.
> > @@ -1234,6 +1242,10 @@
> >  	Note that if the transform value includes 90 or 270 degree rotation,
> >  	the width of the buffer will become the surface height and the height
> >  	of the buffer will become the surface width.
> > +
> > +	If transform is not one of the values from the
> > +	wl_output.transform enum the invalid_transform protocol error
> > +	is raised.
> >        </description>
> >        <arg name="transform" type="int"/>
> >      </request>
> > @@ -1262,6 +1274,9 @@
> >  	Note that if the scale is larger than 1, then you have to attach
> >  	a buffer that is larger (by a factor of scale in each dimension)
> >  	than the desired surface size.
> > +
> > +	If scale is not positive the invalid_scale protocol error is
> > +	raised.
> >        </description>
> >        <arg name="scale" type="int"/>
> >      </request>
> 
> This looks good to me, and since the patch has been on the list for
> over half a year, I will push this on Friday unless no-one objects.

This one and the Weston patch pushed.


Thanks,
pq