[RFCv3 weston 14/15] protocol: add scaler TODO
Pekka Paalanen
ppaalanen at gmail.com
Fri Mar 7 04:04:02 PST 2014
From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
These changes are needed by the queueing in Presentation extension.
---
protocol/scaler.xml | 4 ++++
src/compositor.c | 3 +++
2 files changed, 7 insertions(+)
diff --git a/protocol/scaler.xml b/protocol/scaler.xml
index dfe44b8..f3a7232 100644
--- a/protocol/scaler.xml
+++ b/protocol/scaler.xml
@@ -142,6 +142,10 @@
arguments to wl_surface.attach. The x, y, dst_width, and dst_height
define the surface-local coordinate system irrespective of the
attached wl_buffer size.
+
+ XXX TODO: we need separate requests for src and dst variables,
+ maybe even three: src x,y; src w,h; dst w,h. Define what happens
+ when only src or dst is set.
</description>
<arg name="src_x" type="fixed" summary="source rectangle x"/>
diff --git a/src/compositor.c b/src/compositor.c
index 00213d4..2e5e6d8 100644
--- a/src/compositor.c
+++ b/src/compositor.c
@@ -3862,6 +3862,9 @@ viewport_set(struct wl_client *client,
struct weston_surface *surface =
wl_resource_get_user_data(resource);
+ /* XXX TODO: split wl_viewport.set into separate dst and src
+ * requests */
+
assert(surface->viewport_resource != NULL);
if (wl_fixed_to_double(src_width) < 0 ||
--
1.8.3.2
More information about the wayland-devel
mailing list