[RFCv3 weston 01/15] compositor: refactor more into weston_surface_attach

Daniel Stone daniel at fooishbar.org
Fri Mar 7 15:01:49 PST 2014


Hi,

On 7 March 2014 13:03, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> Merge more code into a common function. No functional changes.

Quick nitpick: does this not break all the pixman_region32_*() calls
in weston_surface_commit(), which rely on surface->{width,height}?
Should be pretty easy to see this breakage when resizing larger with a
steady-state (as opposed to constantly-attaching) client.

Cheers,
Daniel


More information about the wayland-devel mailing list