[PATCH 2/3] weston:Add wl_output name event

Wang, Quanxian quanxian.wang at intel.com
Thu Mar 13 20:06:48 PDT 2014



>-----Original Message-----
>From: Bryce W. Harrington [mailto:b.harrington at samsung.com]
>Sent: Friday, March 14, 2014 10:44 AM
>To: Wang, Quanxian
>Cc: wayland-devel at lists.freedesktop.org; ppaalanen at gmail.com
>Subject: Re: [PATCH 2/3] weston:Add wl_output name event
>
>On Fri, Mar 14, 2014 at 10:27:05AM +0800, Quanxian Wang wrote:
>> Signed-off-by: Quanxian Wang <quanxian.wang at intel.com>
>> ---
>>  src/compositor.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/src/compositor.c b/src/compositor.c index
>> 98a4f6f..8e8964b 100644
>> --- a/src/compositor.c
>> +++ b/src/compositor.c
>> @@ -3045,6 +3045,9 @@ bind_output(struct wl_client *client,
>>  	}
>>
>>  	if (version >= 2)
>> +		wl_output_send_name(resource, output->name);
>> +
>> +	if (version >= 2)
>>  		wl_output_send_done(resource);
>
>Why not just put the two calls in a block?
>
>	if (version >= 2) {
>		wl_output_send_name(resource, output->name);
>		wl_output_send_done(resource);
>	}
[Wang, Quanxian] I found scale and done are separately sent instead of in one block. I don't know why. Therefore I follow their original code style to do that.
>
>>  }
>>
>> --
>> 1.8.1.2
>>
>> _______________________________________________
>> wayland-devel mailing list
>> wayland-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list