[PATCH weston 0/8] wl_viewport enhancements

Pekka Paalanen ppaalanen at gmail.com
Fri Mar 14 05:38:10 PDT 2014

From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>


this series replaces the first 5 patches from

Compared to the old series, this series carries the same 5 patches
rebased on top of the current master branch. It adds a tiny fix
(patch 4).

The big thing added in this series is patch 7, which adds two new
wl_viewport requests for setting the source rectangle and destination
size separately. This will be needed by the Presentation extension,
which classifies source rectangle as buffer state and destination size
as surface state, hence going through different commit paths. Clients
will need a way to set these separately.

We now also define what it means if source rectangle is set, but
destination size is not set, and vice versa.

This patch series does not yet change the wl_surface.commit behaviour.

When wl_scaler/wl_viewport eventually migrates to Wayland, my intention
is to drop the wl_viewport.set request and the error codes. I guess
this would also need to rename the global interface, which gives us
the opportunity to change the interface style from factory to
something else, if we want.

Pekka Paalanen (8):
  compositor: refactor more into weston_surface_attach
  compositor: buffer can be non-NULL only if newly_attached
  compositor: refactor code into weston_surface_reset_pending_buffer()
  compositor: use surface_set_size() in one more case
  compositor: reorganize struct weston_buffer_viewport
  compositor: replace weston_buffer_viewport::viewport_set
  protocol,compositor: split wl_viewport setters
  clients/scaler: add modes to test wl_scaler version 2

 clients/scaler.c      | 143 +++++++++++++++++++++++++++++-----
 desktop-shell/shell.c |   6 +-
 protocol/scaler.xml   |  77 +++++++++++++++----
 src/compositor-drm.c  |  12 +--
 src/compositor.c      | 208 ++++++++++++++++++++++++++++++++++----------------
 src/compositor.h      |  31 +++++---
 src/gl-renderer.c     |   2 +-
 src/pixman-renderer.c |  59 ++++++++------
 8 files changed, 400 insertions(+), 138 deletions(-)



More information about the wayland-devel mailing list