[PATCH 2/3] weston:Add wl_output name event

[Wang, Quanxian]

From: Jason Ekstrand [mailto:jason at jlekstrand.net]
Sent: Saturday, March 15, 2014 3:54 AM
To: Wang, Quanxian
Cc: ppaalanen at gmail.com; wayland-devel at lists.freedesktop.org
Subject: Re: [PATCH 2/3] weston:Add wl_output name event


On Mar 13, 2014 9:12 PM, "Quanxian Wang" <quanxian.wang at intel.com<mailto:quanxian.wang at intel.com>> wrote:
>
> Signed-off-by: Quanxian Wang <quanxian.wang at intel.com<mailto:quanxian.wang at intel.com>>
> ---
>  src/compositor.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/compositor.c b/src/compositor.c
> index 98a4f6f..8e8964b 100644
> --- a/src/compositor.c
> +++ b/src/compositor.c
> @@ -3045,6 +3045,9 @@ bind_output(struct wl_client *client,
>         }
>
>         if (version >= 2)
> +               wl_output_send_name(resource, output->name);

As with my comment on the protocol, wl_output_send_name should be version 3, not version 2.  That should also clear up Bryce's comment.

[Wang, Quanxian] if it is 2, patch 3/3 is not needed because  currently shell only support version 2. Right?

Thanks,
--Jason Ekstrand

> +
> +       if (version >= 2)
>                 wl_output_send_done(resource);
>  }
>
> --
> 1.8.1.2
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org<mailto:wayland-devel at lists.freedesktop.org>
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20140315/119f10b8/attachment-0001.html>