[PATCH] compositor: Use weston_log rather than perror for error messages

[Hardening]

Le 18/03/2014 20:34, Bryce W. Harrington a écrit :
> weston_log() seems to be the standard elsewhere in the codebase for
> errors.  These are the only two instances where perror() is used
> instead, and their error messages aren't that informative anyway.
>
> Signed-off-by: Bryce Harrington <b.harrington at samsung.com>
> ---
>   src/compositor-wayland.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
> index 238946b..83eb59c 100644
> --- a/src/compositor-wayland.c
> +++ b/src/compositor-wayland.c
> @@ -211,13 +211,13 @@ wayland_output_get_shm_buffer(struct wayland_output *output)
>
>   	fd = os_create_anonymous_file(height * stride);
>   	if (fd < 0) {
> -		perror("os_create_anonymous_file");
> +		weston_log("could not create an anonymous file buffer\n");

perror writes a human readable message, perhaps
weston_log("could not create an anonymous file buffer: %s\n", 
strerror(error));

would be better ?

[...]

Regards

-- 
David FORT
website: http://www.hardening-consulting.com/