[PATCH 1/3] protocol: Add an event to specify the name of an output

[Pekka Paalanen]

On Wed, 30 Apr 2014 12:24:40 +0100
Neil Roberts <neil at linux.intel.com> wrote:

> This bumps the version of the wl_output interface to 3 and adds a
> separate event to report the output's name.
> ---
>  protocol/wayland.xml | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> index 330f8ab..60fa81e 100644
> --- a/protocol/wayland.xml
> +++ b/protocol/wayland.xml
> @@ -1645,7 +1645,7 @@
>      </event>
>    </interface>
>  
> -  <interface name="wl_output" version="2">
> +  <interface name="wl_output" version="3">
>      <description summary="compositor output region">
>        An output describes part of the compositor geometry.  The
>        compositor works in the 'compositor coordinate system' and an
> @@ -1783,6 +1783,17 @@
>        </description>
>        <arg name="factor" type="int" summary="scaling factor of output"/>
>      </event>
> +
> +    <!-- Version 3 additions -->
> +
> +    <event name="name" since="3">
> +      <description summary="name of the output">
> +        The name event contains a human-readable name for the output.
> +        If the output has a name then this event is sent after binding
> +        to the output object.
> +      </description>
> +      <arg name="name" type="string" summary="name of the output"/>
> +    </event>
>    </interface>
>  
>    <interface name="wl_region" version="1">

Hi,

were you aware of
http://lists.freedesktop.org/archives/wayland-devel/2014-March/thread.html#13730
perhaps? :-)

Your series is almost identical to Quanxian's, except:
- wording differences, of course
- patch 2 checks if output->name is set before sending (can it ever be
  NULL?)
- patch 2 missed setting the actual protocol object version
- you add support to weston-info in patch 3
- Quanxian adds empty handlers to window.c and desktop-shell.c which
  isn't really necessary


Thanks,
pq