[PATCH weston] window.c: Set the input region of the tooltip to empty

[Pekka Paalanen]

On Mon,  5 May 2014 17:02:15 +0300
Ander Conselvan de Oliveira <conselvan2 at gmail.com> wrote:

> From: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com>
> 
> Otherwise it might receive touch events.
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=78207

Hi,

I added a comment to the bug, as I am not sure the below change
implements an expected behaviour, but I suppose it at least is an
improvement nevertheless.

Note, that at least I never added sub-surface input support to
window.c, I always just ignored that case and assumed the app sets the
input region to empty, as that was all that subsurfaces demo needed.

Panel's tooltips must use a completely different implementation than
normal window's tooltips, assuming xdg_shell gets the explicit tooltip
protocol. Jasper?

I suppose we can keep this patch for now, and come back to it when more
xdg_shell work lands in master. I just wanted to make the note, that
patch is not the end of the story.


Thanks,
pq

> ---
>  clients/window.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/clients/window.c b/clients/window.c
> index b7febed..f667cdf 100644
> --- a/clients/window.c
> +++ b/clients/window.c
> @@ -1992,6 +1992,7 @@ window_create_tooltip(struct tooltip *tooltip)
>  	widget_set_allocation(tooltip->widget,
>  			      tooltip->x, tooltip->y + offset_y,
>  			      extents.width + 20, 20 + margin * 2);
> +	widget_input_region_add(tooltip->widget, NULL);
>  
>  	return 0;
>  }