[PATCH] desktop-shell: Fix black edges on scaled desktop pattern

[Jonas Ådahl]

On Fri, May 09, 2014 at 11:13:54AM -0700, Bill Spitzak wrote:
> 
> 
> On 05/09/2014 02:11 AM, Pekka Paalanen wrote:
> >On Thu, 08 May 2014 20:00:35 -0700
> >Bill Spitzak <spitzak at gmail.com> wrote:
> >
> >>Filter sampling outside the source image can leak black into the edges
> >>of the
> >>desktop image. This is most easily seen by scaling the default tiled image
> >>with this weston.ini:
> >>
> >>	# no background-image and no background-color
> >>	background-type=scale-crop
> >>---
> >>   clients/desktop-shell.c |    2 ++
> >>   1 file changed, 2 insertions(+)
> >>
> >>diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c
> >>index 4880888..e121cc7 100644
> >>--- a/clients/desktop-shell.c
> >>+++ b/clients/desktop-shell.c
> >>@@ -724,6 +724,7 @@ background_draw(struct widget *widget, void *data)
> >>   		case BACKGROUND_SCALE:
> >>   			cairo_matrix_init_scale(&matrix, sx, sy);
> >>   			cairo_pattern_set_matrix(pattern, &matrix);
> >>+			cairo_pattern_set_extend(pattern, CAIRO_EXTEND_PAD);
> >>   			break;
> >>   		case BACKGROUND_SCALE_CROP:
> >>   			s = (sx < sy) ? sx : sy;
> >>@@ -733,6 +734,7 @@ background_draw(struct widget *widget, void *data)
> >>   			cairo_matrix_init_translate(&matrix, tx, ty);
> >>   			cairo_matrix_scale(&matrix, s, s);
> >>   			cairo_pattern_set_matrix(pattern, &matrix);
> >>+			cairo_pattern_set_extend(pattern, CAIRO_EXTEND_PAD);
> >>   			break;
> >>   		case BACKGROUND_TILE:
> >>   			cairo_pattern_set_extend(pattern, CAIRO_EXTEND_REPEAT);
> >
> >Ok, I see the problem, and I see this fix should be good, but for some
> >reason this patch does not apply at all. I had to do the change
> >manually. Anyway, it works right and fixes the issue.
> >
> >Hm, it does apply with --ignore-whitespace, though. When I save the raw
> >email, there seems to be extra spaces in the beginning of all context
> >lines. Maybe Format="flowed" messes it up?
> 
> git send-email did not work (as it wants a mta set up) so I tried to
> do it by hand. Fail.
> 
> If I set up a mta here at work it will look like the email came from
> work. That is not a problem for the mailing list, right? (assuming I
> change the from address to my gmail account).

If you are using gmail, you can just use Googles SMTP server directly.
The example configuration in the manual [0] even is a @gmail.com
address setup.

Jonas

[0] http://git-scm.com/docs/git-send-email

> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel