[PATCH v2] configure.ac: Change in build system to use the path from pkg-config for wayland-scanner.

Neil Roberts neil at linux.intel.com
Thu May 15 06:23:20 PDT 2014


Hi,

Srivardhan Hebbar <sri.hebbar at samsung.com> writes:

> +AC_PATH_PROG([wayland_scanner], [wayland-scanner],,
> +		[${WAYLAND_SCANNER_PATH}])

I don't think it makes much sense to search the path for wayland-scanner
when pkg-config already gives you the complete filename. Instead of
trying to derive a directory to search we could just use the filename
directly and check whether it is executable. Then instead of AC_PATH_PROG it
could do something like this:

AC_MSG_CHECKING([for wayland-scanner])
AS_IF([AS_EXECUTABLE_P([${wayland_scanner}])],
      [AC_MSG_RESULT([${wayland_scanner}])
       AC_SUBST(wayland_scanner)],
      [AC_MSG_RESULT([not found])
       AC_MSG_ERROR([wayland-scanner was not found])])

The --wayland-scanner-path option could also be replaced with something
that would just take the whole filename too.

Regards,
- Neil


More information about the wayland-devel mailing list