[PATCH libinput v3 02/17] touchpad: after a click, lock the finger to its current position

[Hans de Goede]

Hi,

On 05/22/2014 08:05 AM, Peter Hutterer wrote:
> On Tue, May 20, 2014 at 04:34:50PM +0200, Hans de Goede wrote:
>> From: Peter Hutterer <peter.hutterer at who-t.net>
>>
>> On clickpads, clicking the pad usually causes some motion events. To avoid
>> erroneous movements, lock the finger into position on the click and don't
>> allow for motion events until we move past a given threshold (currently 2% of
>> the touchpad diagonal).
>>
>> HdG:
>> Instead of pinning the lowest touch assuming that that is the one holding
>> the physical button, simply pin all touches, and unpin as soon as a touch
>> is moved more then the threshold.
> 
> Can you merge the two commit messages together into one? if we don't have
> the original patch in the tree we don't need the specific history of this
> patch. if you are concerned about preserving authorship feel free to change
> to yourself as author or add a Co-authored-by: tag, either you or me, I
> don't mind either way. That applies to all other patches too please.

Done.

>> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>> Reviewed-by: Jonas Ådahl <jadahl at gmail.com>
>> Reviewed-by: Hans de Goede <hdegoede at redhat.com>
>> Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
>> ---
>>  src/evdev-mt-touchpad.c | 80 ++++++++++++++++++++++++-------------------------
>>  src/evdev-mt-touchpad.h | 12 +++++++-
>>  2 files changed, 50 insertions(+), 42 deletions(-)
>>
>> diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
>> index b4a89e3..381bb90 100644
>> --- a/src/evdev-mt-touchpad.c
>> +++ b/src/evdev-mt-touchpad.c
>> @@ -32,6 +32,7 @@
>>  #define DEFAULT_MIN_ACCEL_FACTOR 0.16
>>  #define DEFAULT_MAX_ACCEL_FACTOR 1.0
>>  #define DEFAULT_HYSTERESIS_MARGIN_DENOMINATOR 700.0
>> +#define DEFAULT_BUTTON_MOTION_THRESHOLD 0.02 /* in percent of size */
> 
> Didn't spot this but the comment should probably be changed to
>         /* 2% of size */ 
> to avoid confusion about it being 2% or 0.02%.

Fixed.

> other than that - series looks good, rev-by where missing if you want. 
> tested on my x220 and on the T440s and it works as expected.
> 
> Send me a pull request for the lot and I'll merge it, no need to re-send all
> these patches.

I'm going through your review comments now, I'll send a pull-req when I'm done.

Regards,

Hans