[PATCH 4/4] queue-test: Add another assertion
philip at tecnocode.co.uk
Sat Nov 1 10:08:52 PDT 2014
On Mon, 2014-09-22 at 11:56 +0300, Pekka Paalanen wrote:
> On Thu, 11 Sep 2014 21:43:49 +0200
> Karsten Otto <karsten.otto at posteo.de> wrote:
> > From: Philip Withnall <philip at tecnocode.co.uk>
> > Date: Fri, 15 Feb 2013 12:57:23 +0000
> > Ensure that the round trip succeeds.
> > [kao: adjusted patch to current test framework style]
> > Signed-off-by: Philip Withnall <philip at tecnocode.co.uk>
> > Signed-off-by: Karsten Otto <ottoka at posteo.de>
> > ---
> > tests/queue-test.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > diff --git a/tests/queue-test.c b/tests/queue-test.c
> > index 96f2100..6e2e932 100644
> > --- a/tests/queue-test.c
> > +++ b/tests/queue-test.c
> > @@ -66,7 +66,7 @@ client_test_proxy_destroy(void)
> > assert(registry != NULL);
> > wl_registry_add_listener(registry, ®istry_listener,
> > &counter);
> > - wl_display_roundtrip(display);
> > + assert(wl_display_roundtrip(display) != -1);
> > assert(counter == 1);
> sorry, all four patches are corrupted: there is no space in front of the
> context lines. Could you try again with git-send-email?
> The same goes for your "Do not abort() the compositor when dup fails
> during fd marshalling".
> The link http://www.freebsd.org/cgi/query-pr.cgi?pr=docs/99356#reply2
> does not work anymore. Can you dig up a new one?
> I commented on patch 3, the rest look good so far.
I’ve updated the patch set and sent it afresh to the list. Patch 3
includes Karsten’s excellent explanation in its commit message (plus the
suggested errno fix). Patch 4 includes his style fix.
I haven’t resent the ‘Do not abort() the compositor when dup fails
during fd marshalling’ patch because that was originally Karsten’s.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 213 bytes
Desc: This is a digitally signed message part
More information about the wayland-devel