[PATCH weston 1/1] compositor: Abort on bad page flip timestamps

Frederic Plourde frederic.plourde at collabora.co.uk
Thu Nov 6 05:09:40 PST 2014


On 14-11-06 02:08 AM, Michel Dänzer wrote:
> On 06.11.2014 03:06, Frederic Plourde wrote:
>> If a pathological case is detected, we gracefully exit Weston
>> with an appropriate exit code to help developers debug their drivers.
>
> That seems a bit harsh. IIRC, zero can be returned for the timestamp 
> intermittently if no accurate timestamp value can be determined, e.g. 
> because the CRTC is disabled. At the very least, I'd recommend 
> double-checking this with Mario Kleiner (Cc'd) and the dri-devel 
> mailing list.
>

Michel : This is useful to drm backend where we get our timestamps from 
the underlying driver. This patch relies on Pekka's presentation 
extension (and all the clock circuitry added in the patch series) and 
IIUC, for other backends, we are using a software clock that may *not* 
show this kind of "intermittent 0 timestamp" behavior. But thanks, 
Michel, I will double check with Mario if DRM can shoot nulled-out 
timerstamps sometimes under normal working conditions.

Pekka: Any hint about what I just said ?...

-- 

<https://www.linkedin.com/in/fredericplourde>*Frédéric Plourde*

/Principal Software engineer/

    *T* :: (450) 415-0855
    *@*:: frederic.plourde at collabora.co.uk
    <mailto:frederic.plourde at collabora.co.uk>

/+++++++++++++/

/Open First ! We're hiring !/

/Our current opportunities can be found here: 
http://bit.ly/Collabora-Careers/

/Visit Collabora on the Web at https://www.collabora.com 
<https://www.collabora.com/>/



More information about the wayland-devel mailing list