[PATCH v2] input: don't send to clients key events eaten by bindings

giuliocamuffo at gmail.com giuliocamuffo at gmail.com
Fri Nov 7 00:14:15 PST 2014

Il ven nov 7 01:57:37 2014 GMT+0200, Bill Spitzak scrive:
> > It may, but that's not the point. The key was eaten by the compositor
> > binding, it must not be sent to the client.
> The key is not being "sent". A map of what keys are pushed down right 
> now is what is sent.
> The user certainly expects the client to act like the key is held down 
> for shift keys, and because of this you are sending an inconsistent 
> shift state that does not match the key-down state.
> What if a client considers the key that triggered the event to be a 
> modifier and acts different if held down? The user is certainly holding 
> it down, so the client will not act correctly if it does not know this.
> More of a concern, what if the user accidentally thinks they have to 
> hold down some unrelated key like 'x'? This will mean that the x will 
> repeat, because it was not "used", but the user certainly cannot see 
> this. Instead, all keys pressed before the action that transferred 
> keyboard focus must act identically, whether or not they were a command.

Listen, there's no point in repeating the same thing over and over again. This doesn't work, as I've explained in http://lists.freedesktop.org/archives/wayland-devel/2014-October/017741.html

Sent from my Jolla

More information about the wayland-devel mailing list