[PATCH weston v3] input: don't send to clients key events eaten by bindings

[Giulio Camuffo]

I'm unsure whether i should reply, but let's try one last time.

2014-11-11 21:27 GMT+02:00 Bill Spitzak <spitzak at gmail.com>:
> Hate to be a pain about this, but the description of the bug (with Mod+x)
> can be reproduced and has nothing to do with whether the compositor shortcut
> was triggered. Try Mod+y (or any other key not consumed by the compositor)
> in an xterm.

It works as expected, what's the problem?

>
> You can argue about whether the 'x' or 'y' should repeat after the Mod key
> was released, but there is absolutely no reason the result should differ
> depending on whether the shortcut went to the server or the client.
>
> I therefore still believe that this proposed fix is a serious blunder and
> should not be done. The correct fix is for clients to get an accurate

Too late, it's in already. It appears evident you're the only one who
thinks that compositor's bindings should not eat the key events, so
your only chance of convincing anyone is to bring real usecases, not
abstract ideas.


--
Giulio

> key-down map whenever they have keyboard focus. This proposed fix instead
> breaks it in the case that it works (when the client gets focus) instead of
> the correct fix of doing something when the shortcut does not cause a focus
> change.
>
> If clients respond in unexpected ways when keys change state than this is a
> bug in the client and needs to be fixed there.