[PATCH weston 0/6] Fixups and rewrites for xdg-shell

[Pekka Paalanen]

On Sat, 22 Nov 2014 12:28:24 -0800
"Jasper St. Pierre" <jstpierre at mecheye.net> wrote:

> This is the last round of fixups I'm going to to the existing
> xdg-shell interface. We'll be adding on other APIs before it
> goes fully stable, but before that, let's focus on making
> sure what we already have is good enough.
> 
> Jasper St. Pierre (6):
>   xdg-shell: Take a xdg_surface as the parent surface
>   xdg-shell: Remove the serial from popup_done
>   xdg-shell: Remove the flags from get_xdg_popup
>   xdg-shell: Send an error when the client uses the not-topmost popup
>   xdg-shell: Rewrite documentation
>   xdg-shell: Bump unstable version
> 
>  clients/simple-damage.c |   2 +-
>  clients/simple-egl.c    |   2 +-
>  clients/simple-shm.c    |   2 +-
>  clients/window.c        |  11 +-
>  desktop-shell/shell.c   |  28 ++++-
>  protocol/xdg-shell.xml  | 269 +++++++++++++++++++++++++++++-------------------
>  6 files changed, 196 insertions(+), 118 deletions(-)
> 

Patches 1, 2, 3, and 6 are
Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

On patch 4 I had one question.

For patch 5 I had some comments, but in general very good improvements.
I like the "serial of the user event", for instance, and the xdg_popup
general explanation is very nice.

Obviously this series should land all at once to minimize the
disruption, so I'll wait for my comments to be addressed and also
comments from others.


Thanks,
pq