[PATCH] Ignore devices that have joystick buttons

Jasper St. Pierre jstpierre at mecheye.net
Tue Nov 25 08:44:26 PST 2014


Well, SDL already opens your gamepad evdev device manually. libinput is
designed for compositors and Wayland, and I don't see any reason to
introduce a gamepad protocol into Wayland if SDL already just uses evdev.

On Tue, Nov 25, 2014 at 8:41 AM, Derek Foreman <derekf at osg.samsung.com>
wrote:

> On 25/11/14 04:32 AM, Peter Hutterer wrote:
> > On Tue, Nov 25, 2014 at 02:33:53AM +0100, Krzysztof A. Sobiecki wrote:
> >> This patch allows libinput to ignore devices that have joystick buttons.
> >>
> >> Signed-off-by: Krzysztof Sobiecki <sobkas at gmail.com>
> >> ---
> >>  src/evdev.c | 9 +++++++++
> >>  1 file changed, 9 insertions(+)
> >>
> >> diff --git a/src/evdev.c b/src/evdev.c
> >> index 36c6859..5f6cc32 100644
> >> --- a/src/evdev.c
> >> +++ b/src/evdev.c
> >> @@ -1274,6 +1274,15 @@ evdev_configure_device(struct evdev_device
> *device)
> >>      has_keyboard = 0;
> >>      has_touch = 0;
> >>
> >> +        for (i = BTN_JOYSTICK; i < BTN_DIGI; i++) {
> >> +                if (libevdev_has_event_code(evdev, EV_KEY, i)) {
> >> +                        log_info(libinput,
> >> +                                 "input device '%s', %s is a joystick,
> ignoring\n",
> >> +                                 device->devname, device->devnode);
> >> +                        return -1;
> >> +                }
> >> +        }
> >> +
> >>      if (libevdev_has_event_type(evdev, EV_ABS)) {
> >>
> >>              if ((absinfo = libevdev_get_abs_info(evdev, ABS_X))) {
> >> --
> >> 2.2.0.rc0.207.ga3a616c
> >
> > merged with a minor change, device->devnode is just devnode in my local
> > tree. thanks.
>
>
> Err, is there some long term plan for gamepad support in libinput?  I'm
> kind of hoping this isn't it... :)
>
> I kind of wonder if gamepads should be implicitly assigned seats
> (player1, player2, etc) and the compositor can choose whether to ignore
> them?
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>



-- 
  Jasper
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20141125/5a1ec3e7/attachment.html>


More information about the wayland-devel mailing list