[PATCH weston] input: don't send to clients key events eaten by bindings

[Giulio Camuffo]

2014-10-08 21:00 GMT+03:00 Bill Spitzak <spitzak at gmail.com>:
>
>
> On 10/08/2014 01:41 AM, Giulio Camuffo wrote:
>>
>> 2014-10-08 0:50 GMT+03:00 Bill Spitzak <spitzak at gmail.com>:
>>>
>>> I really can't imagine this is a problem, and clients may even expect the
>>> current behavior. It certainly is expected for shift keys: if I alt+tab
>>> to a
>>> program it acts like alt is still held down. A quick test on Ubuntu shows
>>> that a program you alt+tab to gets a map with both alt and tab held down.
>>
>>
>> I don't really care much how it works on Ubuntu, honestly. This is a
>> problem because the key binding is supposed to not let the key
>> press/release get to the clients, but this isn't what is happening in
>> reality. Modifiers keys are not affected by this change.
>
>
> A key being held down on focus-in will not produce a "press" event, so I
> don't see what the problem is.

It produces a KeyPress in xwayland.

>
> If a client wants to check if X is held down I think the user expects it to
> work even if it was held down as part of the command to switch windows.
> Therefore I think the current behavior is correct.

Why would it care about that? The compositor decided that the clients
shouldn't know that one key was pressed, so the client's shouldn't
know that. If some client gets to know that it's a bug.
Or else you should say that key bindings should always let the events
pass to clients. Are you saying that?

>
> All I can guess is that this is having some problem with the way wayland is
> implemented. Is it causing unwanted key repeats? Or preventing them when
> they are wanted?? Or are you worried about the client getting a "release"
> event?