[PATCH Weston 1/1] desktop-shell: implement autolaunch

[Daniel Stone]

Hi,

On 22 October 2014 14:53, Pekka Paalanen <pekka.paalanen at collabora.co.uk>
wrote:

> +       pid = fork();
> +       if (pid < 0) {
> +               fprintf(stderr, "fork failed: %m\n");
> +               goto out;
> +       }
> +
> +       if (pid)
> +               goto out;
> +
> +       argvpp = argv.data;
> +       if (execve(argvpp[0], argvpp, envp.data) < 0) {
> +               fprintf(stderr, "execl '%s' failed: %m\n", argvpp[0]);
> +               exit(1);
> +       }
>

Hmm. Can we please use weston_client_start here instead of open-coding it?

And, while you're at it - as this was written for kiosk mode, it spawns a
shell script which just restarts the video player in a loop. Can we please
add an autostart param to weston_client_run/start (as a new enum with
WESTON_CLIENT_RESTART, not bool) and to the config (as a bool) which lifts
most of
desktop_shell_client_destroy/check_desktop_shell_crash_too_early/respawn_desktop_shell_process?

Aside from that, and splitting refactor / autorestart code move / autorun
feature into separate patches, this looks good to me.

Cheers,
Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20141024/d574ab39/attachment.html>