[PATCH weston] xwm: Do not activate override redirect windows

[Pekka Paalanen]

On Sat, 30 Aug 2014 15:24:21 +0900
Ryo Munakata <ryomnktml at gmail.com> wrote:

> On Sat, 30 Aug 2014 10:33:23 +0800
> 
> Hi, Boyan.
> 
> I tested this patch with chromium and firefox running on each drm-backend and x11-backend of weston.
> And seems that both chromium and firefox work well.
> This patch actually fixes bug 81273 in my environment.
> 
> So now:
> Tested-by: Ryo Munakata <ryomnktml at gmail.com>
> 
> Thanks.
> 
> Boyan Ding <stu_dby at 126.com> wrote:
> > We shouldn't do WM-y things on an O-R window, including setting input
> > focus to it.
> > 
> > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=81273
> > Signed-off-by: Boyan Ding <stu_dby at 126.com>
> > ---
> >  xwayland/window-manager.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c
> > index a216b76..bf39fab 100644
> > --- a/xwayland/window-manager.c
> > +++ b/xwayland/window-manager.c
> > @@ -701,6 +701,9 @@ weston_wm_window_activate(struct wl_listener *listener, void *data)
> >  	}
> >  
> >  	if (window) {
> > +		if (window->override_redirect)
> > +			return;
> > +
> >  		client_message.response_type = XCB_CLIENT_MESSAGE;
> >  		client_message.format = 32;
> >  		client_message.window = window->id;

Thank you all, pushed.
- pq