[PATCH libinput 6/8] touchpad: Put state unrolling code in a tp_clear_state() helper function

Hans de Goede hdegoede at redhat.com
Tue Sep 16 07:22:40 PDT 2014


For touchpads with top softbuttons we don't want to fully disable the touchpad
on suspend, as we want to keep the top softbuttons working for the trackpoint.

So in the suspended state some of the touchpad sub-statemachines will keep
running (e.g. buttons) where others (e.g. tap) will not. This means that
we will need to clear the touchpad state on resume too, to avoid things
being in an inconsistent state after resume.

This commit factors out the state clearing code into a helper functions, so
that the same code can be used on resume.

No functional changes.

Signed-off-by: Hans de Goede <hdegoede at redhat.com>
---
 src/evdev-mt-touchpad.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
index 73e08c1..edd1f97 100644
--- a/src/evdev-mt-touchpad.c
+++ b/src/evdev-mt-touchpad.c
@@ -602,7 +602,7 @@ tp_destroy(struct evdev_dispatch *dispatch)
 }
 
 static void
-tp_suspend(struct tp_dispatch *tp, struct evdev_device *device)
+tp_clear_state(struct tp_dispatch *tp, struct evdev_device *device)
 {
 	uint64_t now = libinput_now(tp->device->base.seat->libinput);
 	struct tp_touch *t;
@@ -626,7 +626,12 @@ tp_suspend(struct tp_dispatch *tp, struct evdev_device *device)
 	}
 
 	tp_handle_state(tp, now);
+}
 
+static void
+tp_suspend(struct tp_dispatch *tp, struct evdev_device *device)
+{
+	tp_clear_state(tp, device);
 	evdev_device_suspend(device);
 }
 
-- 
2.1.0



More information about the wayland-devel mailing list