[PATCH 4/5] tests: Cleanup test log filenames
Pekka Paalanen
ppaalanen at gmail.com
Thu Apr 2 03:50:30 PDT 2015
On Wed, 1 Apr 2015 19:17:06 -0700
Bryce Harrington <bryce at osg.samsung.com> wrote:
> The log files were being named like:
>
> surface-global-test.la-log.txt
> surface-global-test.la-serverlog.txt
> surface-test.la-log.txt
> surface-test.la-serverlog.txt
> text.weston-log.txt
> text.weston-serverlog.txt
>
> For consistency, omit the test filename's extension (.la/.so).
>
> Signed-off-by: Bryce Harrington <bryce at osg.samsung.com>
> ---
> tests/weston-tests-env | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/weston-tests-env b/tests/weston-tests-env
> index 02c89b4..3cb3073 100755
> --- a/tests/weston-tests-env
> +++ b/tests/weston-tests-env
> @@ -13,8 +13,8 @@ LOGDIR=$abs_builddir/logs
>
> mkdir -p "$LOGDIR"
>
> -SERVERLOG="$LOGDIR/$1-serverlog.txt"
> -OUTLOG="$LOGDIR/$1-log.txt"
> +SERVERLOG="$LOGDIR/${TEST_NAME}-serverlog.txt"
> +OUTLOG="$LOGDIR/${TEST_NAME}-log.txt"
>
> rm -f "$SERVERLOG"
>
Mm, does it matter? I suppose we should make sure we do not have
same-named but different-typed tests.
Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
Thanks,
pq
More information about the wayland-devel
mailing list