[PATCH] config: use simpler regexp syntax to get dot version

Bryce Harrington bryce at osg.samsung.com
Tue Apr 7 15:48:52 PDT 2015


On Thu, Apr 02, 2015 at 07:37:07PM -0700, Bryce Harrington wrote:
> On Thu, Apr 02, 2015 at 07:20:00PM -0700, Bill Spitzak wrote:
> > I wasted a lot of time before I figured out that I needed to add those
> > square brackets to get this to work. Sigh...
> 
> Lots clearer too.
> 
> Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>

pushed
   c45be3d..313b26f  master -> master

  
> > ---
> >  configure.ac |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 6bbec59..271eec3 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -141,7 +141,7 @@ if test "x$enable_documentation" = "xyes"; then
> >  		AC_MSG_ERROR([Documentation build requested but graphviz's dot not found. Install graphviz or disable the documentation using --disable-documentation])
> >  	fi
> >  	AC_MSG_CHECKING([for compatible dot version])
> > -	dot_version=`$DOT -V 2>&1|$GREP -oP '(?<=version\W)@<:@0-9.@:>@*(?=\W(.*))'`
> > +	dot_version=`$DOT -V 2>&1|$GREP -o ['[0-9]*\.[0-9]*\.[0-9]*']`
> >  	AS_VERSION_COMPARE([$dot_version], [2.26.0],
> >  	                   [AC_MSG_RESULT([no])
> >  	                    AC_MSG_ERROR([Graphviz dot $dot_version too old. Graphviz 2.26+ required for documentation build. Install required graphviz version or disable the documentation using --disable-documentation])],
> > -- 
> > 1.7.9.5
> > 
> > _______________________________________________
> > wayland-devel mailing list
> > wayland-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/wayland-devel
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list