[PATCH weston 07/17] xdg-shell: Document that xdg_surface.set_window_geometry needs a commit

Bryce Harrington bryce at osg.samsung.com
Tue Apr 7 18:05:24 PDT 2015


On Tue, Apr 07, 2015 at 05:01:22PM +0800, Jonas Ådahl wrote:
> Signed-off-by: Jonas Ådahl <jadahl at gmail.com>

Small typo, otherwise lgtm.

Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>

(Should this patch be squashed with one of the others?)

> ---
>  protocol/xdg-shell.xml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
> index d316e06..d013803 100644
> --- a/protocol/xdg-shell.xml
> +++ b/protocol/xdg-shell.xml
> @@ -370,6 +370,9 @@
>          portions like drop-shadows which should be ignored for the
>          purposes of aligning, placing and constraining windows.
>  
> +        The window geometry is double buffered, and will be applied the

applied *at* the ?

> +        time wl_surface.commit of the corresponding wl_surface is called.
> +
>          Once the window geometry of the surface is set once, it is not
>          possible to unset it, and it will remain the same until
>          set_window_geometry is called again, even if a new subsurface or
> -- 
> 2.1.4
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list