[PATCH weston 3/3] xwm: Test hash_table_lookup() returns

Pekka Paalanen ppaalanen at gmail.com
Wed Apr 8 05:11:59 PDT 2015


On Tue, 07 Apr 2015 13:48:59 -0500
Derek Foreman <derekf at osg.samsung.com> wrote:

> > I don't like the temporary variable, it seems like you can just put the
> > call to hash_table_lookup in the if statement and it will be clearer.
> 
> I dunno, the if statement pretty much always exceeds 80 cols and I have
> to break it into a couple of lines and it starts to look pretty crappy.

Yeah, let's prefer helper variables.

Thanks,
pq


More information about the wayland-devel mailing list