[PATCH weston v2] xwm: Add and use helper function for looking up windows in the hash table

Pekka Paalanen ppaalanen at gmail.com
Thu Apr 9 23:36:16 PDT 2015

On Thu,  9 Apr 2015 10:51:22 -0500
Derek Foreman <derekf at osg.samsung.com> wrote:

> This lets us verify that all callers are actually testing for a
> successful hash lookup at compile time.
> All current users of hash_table_lookup are converted to the new
> wm_lookup_window() and the appropriate success check is added.
> This fixes any call sites that used to assume a successful return
> and dereference a NULL pointer.
> This closes http://bugs.freedesktop.org/show_bug.cgi?id=83994
> The xwayland test has been failing because weston crashes due to
> a hash lookup failure and a subsequent dereference of the returned
> NULL pointer.
> Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
> ---
> Changes from last version:
> Pass struct weston_wm instead of struct hash_table to wm_lookup_window
> no more temp vars
> drop the cast in weston_wm_read_properties
>  xwayland/window-manager.c | 59 +++++++++++++++++++++++++++++------------------
>  1 file changed, 37 insertions(+), 22 deletions(-)

Great! Pushed.
   46804ca..4937214  master -> master


More information about the wayland-devel mailing list