[PATCH weston] build: fix setuid check

Derek Foreman derekf at osg.samsung.com
Fri Apr 10 09:55:27 PDT 2015


At least in some shells test needs 3 arguments for string comparison

if test $foo=yes ...

will always be true.

if test $foo = yes ...

will perform a string comparison.

Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index c1347b8..2f16fac 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -165,7 +165,7 @@ install-exec-hook:
 	chown root $(DESTDIR)$(bindir)/weston-launch \
 		&& chmod u+s $(DESTDIR)$(bindir)/weston-launch \
 		&& can_suid_files=yes;\
-	if test $$can_suid_files=no; then \
+	if test $$can_suid_files = no; then \
 		echo 'Error: unable to unable to change ownership/setuid on weston-launch.'; \
 		echo 'To skip this step, re-run ./configure using --disable-setuid-install'; \
 		false; \
-- 
2.1.4



More information about the wayland-devel mailing list