[PATCH libinput 0/3] Fix Lenovo X230 series touchpad

[Benjamin Tissoires]

On Mon, Apr 13, 2015 at 2:49 AM, Giulio Camuffo <giuliocamuffo at gmail.com> wrote:
> Hi,
>
> I've been testing it for the last couple days, and i think it's an
> improvement. However i think it could be better still, i feel the
> pointer is too slow when moving the finger at a normal speed.
>

Hi Giulio,

I see what you mean. Jumping from a regular touchpad to this one makes
the X230 touchpad really slow.

I, however do not use the X230 enough to be able to find a comfortable
setting that would be good enough for anybody. And as soon as I change
one parameter, it's difficult to judge if it was faster/better or not
than before :(
If you have some time, you can play with the various factors in
touchpad_lenovo_x230_accel_profile() in src/filter.c.

I think multiplying by 1.5 (or 2.0) the incline parameter feels closer
than other touchpads, so I would encourage you to check on that first.

Feel free to send the various parameters you set, and we will see if
we can include them (after comparison with other touchpads :-P).

Cheers,
Benjamin

>
> --
> Giulio
>
> 2015-04-09 20:30 GMT+03:00 Benjamin Tissoires <benjamin.tissoires at gmail.com>:
>> Hi,
>>
>> Here is a series to try making the touchpad found on the Lenovo
>> X230 working. This touchpad has a very bad hardware resolution and by
>> default, libinput jumps the cursor for 10 pixels at least whenever the
>> user moves the finger.
>>
>> This series adds a special tag for such hardware and provides a separate
>> acceleration profile for them. As mentioned in the documentation, nobody
>> but X230 owners should use this tag.
>>
>> The fourth patch of the series is not required per se, given that we should
>> push this through hwdb and not have a custom fix in libinput. With it, the
>> touchpad felt a little bit better, but that's maybe just me.
>> It's up to the libinput maintainer to decide to take it or not (thus the 4/3).
>>
>> Final note. I tested it on a X230t (t for tablet). I'd like to get some
>> feedbacks from the non-tablet users too.
>>
>> Cheers,
>> Benjamin
>>
>> Benjamin Tissoires (4):
>>   filter: break out accel_profile_linear from
>>     pointer_accel_profile_linear
>>   evdev: use a different filter for low resolution touchpad on the
>>     Lenovo X230
>>   udev: add a custom udev rule for X230 touchpads
>>   evdev: Fix reported resolution of Lenovo X230 touchpads
>>
>>  doc/device-configuration-via-udev.dox |    9 +++++
>>  src/evdev-mt-touchpad.c               |    4 ++-
>>  src/evdev.c                           |   21 +++++++++++++
>>  src/evdev.h                           |    2 +
>>  src/filter.c                          |   53 +++++++++++++++++++++++++++++---
>>  src/filter.h                          |    5 +++
>>  udev/99-x230.rules                    |   14 +++++++++
>>  udev/Makefile.am                      |    4 ++-
>>  8 files changed, 105 insertions(+), 7 deletions(-)
>>  create mode 100644 udev/99-x230.rules
>>
>> _______________________________________________
>> wayland-devel mailing list
>> wayland-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/wayland-devel