[PATCH weston] input: Don't use uninitialized variables in default_grab_pointer_focus()

Daniel Stone daniel at fooishbar.org
Thu Apr 16 13:44:55 PDT 2015


On 16 April 2015 at 21:02, Derek Foreman <derekf at osg.samsung.com> wrote:
> exposay is the only caller that tries to use non 0 with a NULL view, and
> I haven't been able to figure out a reason why that's useful - we've
> just declared that case to be invalid.  I'm planning to just make that 0
> too.

>From taking a look at the code, this can indeed just be removed and
changed to (0, 0). Not only is this not helpful, but it's doubly
invalid: weston_pointer_set_focus() takes sx and sy, not global x/y.
So, I can't see how that could ever have done anything useful. Ack to
anything which changes it to what it should be.


More information about the wayland-devel mailing list