[PATCH wayland v2 3/3] wayland-egl: add a core header

Pekka Paalanen ppaalanen at gmail.com
Thu Apr 30 04:36:06 PDT 2015


On Wed, 29 Apr 2015 13:18:22 +0300
Pekka Paalanen <ppaalanen at gmail.com> wrote:

> On Tue, 28 Apr 2015 22:57:18 +0300
> Giulio Camuffo <giuliocamuffo at gmail.com> wrote:
> 
> > The new core header doesn't include any other header, since it really
> > is not needed.
> > ---
> >  Makefile.am            |  1 +
> >  src/wayland-egl-core.h | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++
> >  src/wayland-egl.h      | 29 +-------------------------
> >  3 files changed, 58 insertions(+), 28 deletions(-)
> >  create mode 100644 src/wayland-egl-core.h

> > -#ifdef  __cplusplus
> > -}
> > -#endif
> > +#include "wayland-egl-core.h"
> 
> Hmm, that looks funny:
> 
> #include <wayland-client.h>
> #include "wayland-egl-core.h"
> 
> I think the wayland-client.h should be in "" to match the style of
> every other include in the wayland headers, but fixing that should be a
> separate patch. Reading cpp.info, "" is correct.
> 
> Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

With Jason' R-b added, pushed.
   d74a9c0..ea73cb0  master -> master


Thanks,
pq


More information about the wayland-devel mailing list