[PATCH wayland v4] scanner: add a new --include-core-only option

Pekka Paalanen ppaalanen at gmail.com
Thu Apr 30 04:49:05 PDT 2015

On Wed, 29 Apr 2015 11:11:48 -0700
Bill Spitzak <spitzak at gmail.com> wrote:

> Forcing --include-core-only on in wayland-scanner, the attached patch 
> makes Weston compile. This involved adding two wayland-client-protocol.h 
> includes.

Thanks for testing.

> IMHO it is better to require this small bit of editing than to continue 
> to include a header with the comment "Use of this header file is 
> discouraged" inside required header files.
> A more complete patch would be to eradicate use of wayland-client.h 
> everywhere. In most cases it is replaced with wayland-client-protocol.h 
> though it should be checked when wayland-client-core.h works.

But we have no reason to push people away from the old headers. Those
who need the new headers know already that the old ones are awkward.
Those who don't need the new headers are welcome to keep using the old
ones. That's why we're not adding a #warn in the old headers either, at
least not until we want to push people away from them.

IOW, you're actually proposing to remove the comment from the headers.
I'm fine either way.


More information about the wayland-devel mailing list