[PATCH weston 13/17] xdg-shell: Some xdg_popup clarifications

[Pekka Paalanen]

On Tue, 7 Apr 2015 19:40:12 -0700
Bryce Harrington <bryce at osg.samsung.com> wrote:

> On Tue, Apr 07, 2015 at 05:01:28PM +0800, Jonas Ådahl wrote:
> > Signed-off-by: Jonas Ådahl <jadahl at gmail.com>
> 
> Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>
> 
> > ---
> >  protocol/xdg-shell.xml | 13 ++++++++-----
> >  1 file changed, 8 insertions(+), 5 deletions(-)
> > 
> > diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
> > index 6d02510..84d39bb 100644
> > --- a/protocol/xdg-shell.xml
> > +++ b/protocol/xdg-shell.xml
> > @@ -516,11 +516,14 @@
> >        A parent surface must be mapped before the new popup is mapped.
> >  
> >        When compositors choose to dismiss a popup, they will likely
> > -      dismiss every nested popup as well.
> > -
> > -      The x and y arguments specify where the top left of the popup
> > -      should be placed, relative to the local surface coordinates of the
> > -      parent surface.
> > +      dismiss every nested popup as well. When a compositor dismisses
> > +      popups, it will follow the same dismissing order as required
> > +      by the client.

Required from the client, not by the client, right?

> > +
> > +      The x and y arguments passed when creating the popup object specify
> > +      where the top left of the popup should be placed, relative to the
> > +      local surface coordinates of the parent surface. See
> > +      xdg_shell.get_xdg_popup.
> >  
> >        For a xdg_popup to be mapped by the compositor, the wl_surface must
> >        have a buffer attached to it, and wl_surface.commit must have been

Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Not a reason for version bump.


Thanks,
pq