[PATCH weston] compositor-rdp: rdp_destroy() double free error #91457

Dawid Gajownik gajownik at gmail.com
Wed Aug 5 13:05:34 PDT 2015


On Wed, Aug 5, 2015 at 4:18 PM, Derek Foreman <derekf at osg.samsung.com> wrote:
> This looks good to me barring two tiny style nits below.
> That fixed,
> Reviewed-by: Derek Foreman <derekf at osg.samsung.com>

Thanks for the information. Does Weston follow the same coding style
as Wayland [1]? The mistakes that I made are also present in other
files:

[user at atomic weston]$ grep -r 'for(' . | wc -l
11
[user at atomic weston]$ grep -r 'if(' . | wc -l
47

BTW I also noticed that some functions in src/compositor-rdp.c are defined like

func_name(argument)
{
        a();
}

and other, for example rdp_client_activity() or xf_extendedMouseEvent():

func_name2(argument) {
        a();
}

I guess the former is correct? I know that it's rather cosmetic issue
but if you think that's worth fixing I could prepare a patch.

[1] http://cgit.freedesktop.org/wayland/wayland/tree/doc/Contributing

Thanks,
     Dawid


More information about the wayland-devel mailing list