[PATCH weston] compositor-rdp: rdp_destroy() double free error #91457

[Bryce Harrington]

On Wed, Aug 05, 2015 at 03:24:01PM -0500, Derek Foreman wrote:
> On 05/08/15 03:05 PM, Dawid Gajownik wrote:
> > On Wed, Aug 5, 2015 at 4:18 PM, Derek Foreman <derekf at osg.samsung.com> wrote:
> >> This looks good to me barring two tiny style nits below.
> >> That fixed,
> >> Reviewed-by: Derek Foreman <derekf at osg.samsung.com>
> > 
> > Thanks for the information. Does Weston follow the same coding style
> > as Wayland [1]? The mistakes that I made are also present in other
> > files:
> 
> Yes, they should be the same.
> 
> > [user at atomic weston]$ grep -r 'for(' . | wc -l
> > 11
> > [user at atomic weston]$ grep -r 'if(' . | wc -l
> > 47
> 
> Yeah, there are lots of violations.  :(
> 
> > BTW I also noticed that some functions in src/compositor-rdp.c are defined like
> > 
> > func_name(argument)
> > {
> >         a();
> > }
> > 
> > and other, for example rdp_client_activity() or xf_extendedMouseEvent():
> > 
> > func_name2(argument) {
> >         a();
> > }
> > 
> > I guess the former is correct? I know that it's rather cosmetic issue
> > but if you think that's worth fixing I could prepare a patch.
> 
> Yeah, the former is the correct style for the project.
> 
> If you feel like writing the patch I'll happily review it.  :)

And I'd happily land it.  :-)

Since it'll likely be a large patch, just make sure the style fix is the
only change in it, so that it's simple to review.

Bryce
 
> > [1] http://cgit.freedesktop.org/wayland/wayland/tree/doc/Contributing
> > 
> > Thanks,
> >      Dawid
> > _______________________________________________
> > wayland-devel mailing list
> > wayland-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/wayland-devel
> > 
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel