[PATCH wayland 2/2] scanner: wrap few long lines

Pekka Paalanen ppaalanen at gmail.com
Mon Aug 17 04:27:12 PDT 2015


On Thu, 23 Jul 2015 11:19:00 -0700
Bryce Harrington <bryce at osg.samsung.com> wrote:

> On Thu, Jul 16, 2015 at 01:59:05PM +0200, Marek Chalupa wrote:
> > Wrap few long lines to the length around 80 chars
> > 
> > Signed-off-by: Marek Chalupa <mchqwerty at gmail.com>
> 
> How hard core are we about maintaining the 80-column rule?  Frankly I
> think the original code with the logging message on one line is more
> readable.

Eh, case by case... my personal feeling is that breaking a string
literal into pieces is not worth it if it's just a little too long.
Breaking it might hinder grep-ability. If there is a natural point to
split, like a newline, then of course split.

Let's try to do the best for readability. *pq waves hands*

I think I'd still split the other arguments from a function call,
though, at the comma.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20150817/4b86f939/attachment.sig>


More information about the wayland-devel mailing list