[PATCH libinput 2/2] enable -Wall -Werror for CFLAGS

[Pekka Paalanen]

On Thu, 20 Aug 2015 12:51:38 +0200
Andreas Pokorny <andreas.pokorny at canonical.com> wrote:

> Just a small change in test is necessary to enable -Wall -Werror.
> 
> Signed-off-by: Andreas Pokorny <andreas.pokorny at canonical.com>
> ---
>  configure.ac  | 4 ++--
>  test/litest.c | 8 ++++++--
>  2 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 885cb39..b7597f0 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -87,8 +87,8 @@ AC_CHECK_LIB([m], [atan2])
>  AC_CHECK_LIB([rt], [clock_gettime])
>  
>  if test "x$GCC" = "xyes"; then
> -	GCC_CXXFLAGS="-Wall -Wextra -Wno-unused-parameter -g -fvisibility=hidden"
> -	GCC_CFLAGS="$GCC_CXXFLAGS -Wmissing-prototypes -Wstrict-prototypes"
> +	GCC_CXXFLAGS="-Wall -Werror -Wextra -Wno-unused-parameter -g -fvisibility=hidden"
> +	GCC_CFLAGS="$GCC_CXXFLAGS -Wall -Werror -Wmissing-prototypes -Wstrict-prototypes"

Hi,

are you sure you want to force -Werror on everyone? Even distribution
builds?

New compilers come out with new warnings, new or old headers might
cause warnings...

While checking with colleagues, I was pointed at
https://www.gnu.org/software/autoconf-archive/ax_compiler_flags.html
Maybe that could inspire something?


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20150820/431e7fc2/attachment.sig>