[PATCH weston] compositor-drm: rename outputs to follow kernel style

Pekka Paalanen ppaalanen at gmail.com
Fri Aug 21 04:50:57 PDT 2015


On Thu, 20 Aug 2015 11:05:39 -0700
Bryce Harrington <bryce at osg.samsung.com> wrote:

> On Thu, Aug 20, 2015 at 10:04:45AM +0300, Pekka Paalanen wrote:
> > On Wed, 19 Aug 2015 10:46:41 -0500
> > Derek Foreman <derekf at osg.samsung.com> wrote:
> > 
> > > Excellent!
> > > 
> > > Incidentally, this is also how Enlightenment names its outputs.
> > > 
> > > Reviewed-by: Derek Foreman <derekf at osg.samsung.com>
> > 
> > Cheers.
> > 
> > Any objections to landing this for 1.9-beta? It does force users to fix
> > their weston.ini if they have any DRM output configurations there.
> 
> No objections, if it can be landed soonish.  It'd be nice if someone
> could test it out manually just for a sanity check.

With a tested-by from sircmpwn in irc, pushed:
   cf34dc2..89c49b3  master -> master


Thanks,
pq

> > > On 19/08/15 07:54 AM, Pekka Paalanen wrote:
> > > > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > > > 
> > > > The problem with the old table of names is that it contains duplicates.
> > > > It is possible to end up with multiple outputs with the same name. In
> > > > that case you cannot write individual configurations for these outputs
> > > > in weston.ini, because they are matched by the name.
> > > > 
> > > > Change all names to follow the kernel naming scheme set in
> > > > drivers/gpu/drm/drm_crtc.c. The snprintf format now follows the kernel
> > > > style, too. Use the DRM_MODE_CONNECTOR_* macros rather than implicit
> > > > table ordering.
> > > > 
> > > > Completely new entries in the table are "Virtual" and "DSI".
> > > > 
> > > > There should not be any gaps in the macro values, but if there are, deal
> > > > with a NULL entry.
> > > > 
> > > > Also change "UNKNOWN" to "UNNAMED" so it's easier to distinguish from
> > > > "Unknown" by the kernel.
> > > > 
> > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89361
> > > > Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > > > ---
> > > >  src/compositor-drm.c | 42 +++++++++++++++++++++++-------------------
> > > >  1 file changed, 23 insertions(+), 19 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20150821/f69db39d/attachment.sig>


More information about the wayland-devel mailing list