[PATCH weston 0/3] start making backends not weston specific

[Pekka Paalanen]

On Mon, 24 Aug 2015 17:58:44 -0700
Bryce Harrington <bryce at osg.samsung.com> wrote:

> On Mon, Aug 17, 2015 at 11:29:01AM +0300, Pekka Paalanen wrote:
> > On Thu, 13 Aug 2015 12:30:00 +0200
> > Giulio Camuffo <giuliocamuffo at gmail.com> wrote:
> > 
> > > The first patch by Pekka adds some functions to ease a smooth migration
> > > from the old way of initializing the backends to a new one which is
> > > libweston friendly.
> > > The other two patches make the drm and wayland backends use that new way.
> > > The other backends will follow if we're ok with the direction this is going.
> > > 
> > > Giulio Camuffo (2):
> > >   drm: port the drm backend to the new init api
> > >   wayland: port the wayland backend to the new api
> > > 
> > > Pekka Paalanen (1):
> > >   compositor: prep for migration to new config system
> > > 
> > >  Makefile.am               |   6 +
> > >  src/compositor-drm.c      | 233 +++++++++------------------
> > >  src/compositor-drm.h      |  89 +++++++++++
> > >  src/compositor-fbdev.c    |   3 +-
> > >  src/compositor-headless.c |   3 +-
> > >  src/compositor-rdp.c      |   3 +-
> > >  src/compositor-rpi.c      |   3 +-
> > >  src/compositor-wayland.c  | 219 +++++---------------------
> > >  src/compositor-wayland.h  |  58 +++++++
> > >  src/compositor-x11.c      |   3 +-
> > >  src/compositor.h          |  21 ++-
> > >  src/main.c                | 392 ++++++++++++++++++++++++++++++++++++++++++++--
> > >  12 files changed, 675 insertions(+), 358 deletions(-)
> > >  create mode 100644 src/compositor-drm.h
> > >  create mode 100644 src/compositor-wayland.h
> > > 
> > 
> > Hi all,
> > 
> > what do people think of landing this stuff before the 1.9-beta release,
> > would anyone object? IMO it's ok as it's only Weston internals
> > restructuring.
> 
> Conceptually I like the patches, but the changes seem a little jumbled.
> I'll try and provide more constructive feedback separately.
> 
> While these mostly just are refactoring internals, the size of the
> patches worries me a bit simply that the quantity of code changes might
> hide a bug or two.  Correct me if I'm wrong, but more work is still
> needed before libweston is a usable library for end users, and whether
> this lands or waits a bit won't impact that?  Assuming that's true, I'd
> kind of prefer holding off on landing these until 1.10, and get a bit
> more review and testing done on them.

Yes, that's true. There is no way 1.9 could end up building a
libweston.so, that we already decided.

(And I'm specifically talking about just building libweston.so, because
the jump from that to a "usable library" is still a long and subjective
one, IMHO.)

I'm ok with holding these off, it gives some slack in my own schedule,
too.

> Maybe there's some smaller bits that would be ok to land; I'll try to
> flag what looks safe to me.

Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20150825/c323048d/attachment.sig>