[PATCH libinput 6/8] tablet: support tool-specific pressure offsets

Peter Hutterer peter.hutterer at who-t.net
Tue Dec 1 20:16:19 PST 2015


On Tue, Dec 01, 2015 at 06:48:41PM -0800, Bill Spitzak wrote:
> On Tue, Dec 1, 2015 at 5:46 PM, Peter Hutterer <peter.hutterer at who-t.net>
> wrote:
> 
> >
> > +       switch (tool->type) {
> > +       case LIBINPUT_TABLET_TOOL_TYPE_PEN:
> > +               strtype = "PEN";
> > +               break;
> > +       case LIBINPUT_TABLET_TOOL_TYPE_BRUSH:
> > +               strtype = "BRUSH";
> > +               break;
> > +       case LIBINPUT_TABLET_TOOL_TYPE_AIRBRUSH:
> > +               strtype = "AIRBRUSH";
> > +               break;
> > +       case LIBINPUT_TABLET_TOOL_TYPE_PENCIL:
> > +               strtype = "PENCIL";
> > +               break;
> > +       case LIBINPUT_TABLET_TOOL_TYPE_ERASER:
> > +               strtype = "RUBBER";
> > +               break;
> >
> > Is there a good reason for this inconsistency in the strings? Ie why isn't
> the last strtype "ERASER".

I suspect whoever submitted the linux/input.h patches was a Brit. Everything
Wacom-related, driver and userspace, refers to it as eraser. Since this is a
hardware-property that effectively overrides kernel data we stick with the
kernel terminology, in libinput we use American English to prevent the 'u'
key from wearing out.
 
Cheers,
   Peter


More information about the wayland-devel mailing list