[PATCH] cosmetic: Remove use of C++ style comments

Nils Chr. Brause nilschrbrause at gmail.com
Thu Dec 3 07:54:51 PST 2015


Hi,

On Thu, Dec 3, 2015 at 4:31 PM, Chris Michael <cp.michael at samsung.com> wrote:
> Signed-off-by: Chris Michael <cp.michael at samsung.com>
> ---
>  src/compositor-rdp.c      | 2 +-
>  src/vaapi-recorder.c      | 2 +-
>  tests/weston-test.c       | 2 +-
>  xwayland/window-manager.c | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c
> index 1098f01..412719d 100644
> --- a/src/compositor-rdp.c
> +++ b/src/compositor-rdp.c
> @@ -717,7 +717,7 @@ struct rdp_to_xkb_keyboard_layout rdp_keyboards[] = {
>         {KBD_NORWEGIAN, "no", 0},
>         {KBD_POLISH_PROGRAMMERS, "pl", 0},
>         {KBD_POLISH_214, "pl", "qwertz"},
> -       // {KBD_PORTUGUESE_BRAZILIAN_ABN0416, 0},
> +       /* {KBD_PORTUGUESE_BRAZILIAN_ABN0416, 0}, */
>         {KBD_ROMANIAN, "ro", 0},
>         {KBD_RUSSIAN, "ru", 0},
>         {KBD_RUSSIAN_TYPEWRITER, "ru", "typewriter"},
> diff --git a/src/vaapi-recorder.c b/src/vaapi-recorder.c
> index 1fd7ebe..1228f7d 100644
> --- a/src/vaapi-recorder.c
> +++ b/src/vaapi-recorder.c
> @@ -200,7 +200,7 @@ bitstream_put_ue(struct bitstream *bs, unsigned int val)
>                 size_in_bits++;
>         }
>
> -       bitstream_put_ui(bs, 0, size_in_bits - 1); // leading zero
> +       bitstream_put_ui(bs, 0, size_in_bits - 1); /* leading zero */
>         bitstream_put_ui(bs, val, size_in_bits);
>  }
>
> diff --git a/tests/weston-test.c b/tests/weston-test.c
> index b6ae91a..03e2c54 100644
> --- a/tests/weston-test.c
> +++ b/tests/weston-test.c
> @@ -390,7 +390,7 @@ test_screenshot_frame_notify(struct wl_listener *listener, void *data)
>                 return;
>         }
>
> -       // FIXME: Needs to handle output transformations
> +       /* FIXME: Needs to handle output transformations */
>
>         compositor->renderer->read_pixels(output,
>                                           compositor->read_format,
> diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c
> index 9398d24..a3f1954 100644
> --- a/xwayland/window-manager.c
> +++ b/xwayland/window-manager.c
> @@ -1715,7 +1715,7 @@ weston_wm_destroy_cursors(struct weston_wm *wm)
>  static int
>  get_cursor_for_location(enum theme_location location)
>  {
> -       // int location = theme_get_location(t, x, y, width, height, 0);
> +       /* int location = theme_get_location(t, x, y, width, height, 0); */
>
>         switch (location) {
>                 case THEME_LOCATION_RESIZING_TOP:
> --
> 2.6.2
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel

C++ style comments are part of C since 1999. I don't see why we shoudn't use
them, since they are much easier to use for single line comments.

Cheers,
Nils


More information about the wayland-devel mailing list